D8608: Fix crash in KAStatsFavouritesModel

David Edmundson noreply at phabricator.kde.org
Wed Nov 1 23:39:39 UTC 2017


davidedmundson created this revision.
davidedmundson added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  KAStatsFavouritesModel doesn't initialise a D-pointer for the lifespan
  of the KAStatsFavouritesModel, like the name implies.
  
  It is set in initForClient.
  
  If the activity changes before we have a client ID, there's no point
  doing anything and trying to use the clientID will crash.
  
  BUG: 386439

TEST PLAN
  None.

REPOSITORY
  R119 Plasma Desktop

BRANCH
  master

REVISION DETAIL
  https://phabricator.kde.org/D8608

AFFECTED FILES
  applets/kicker/plugin/kastatsfavoritesmodel.cpp

To: davidedmundson, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20171101/4b1e5ac8/attachment.html>


More information about the Plasma-devel mailing list