D6011: let's continue in debug code instead of returning from XRandRConfig::applyKScreenConfig

[Christoph Lutz]

clutz created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  There is code for some yet not fixed bug in XRandRConfig::applyKScreenConfig that should print debug information in case of currentMode is NULL. This situation should not happen but was seen in the past. After printing the debug info, the method directly returned from applyKScreenConfig, omitting all the other potentially useful initializations code that comes afterwards.
  
        
  
  From my POV this is wrong and we had situations in which desktop initialization works better if we don't return here. That's why I changed "return" into "continue".

TEST PLAN
  The concrete situation in which I regularily got this currentMode == NULL situation leads to the following bug:
  
        
    - kernel 3.13.0
    - physical pc with two displays, one 4:3 and the other 16:9 format
    - forced the system to always start in clone-mode if there is not
      yet a user profile --> we patched kscreen therefore
    - doing the following workflow:
        - log in --> sessions comes up in clone mode (as wished)
        - autorandr-gui --> "extended desktop - left"
        - press OK and DON't store the profile (so no change is stored)
        - log off
        - log in again
    - The following things happen:
        - Now we run into this "currentMode == NULL" situation (message in log file)
        - the screens come up in clone mode (as the previous settings were not saved)
        - BUG: the resolutions are wrong (parts from one of the two screens are cut).
               applyKScreenConfig returned before it was finished.
        
  
  With this chage, this bug no longer occures and the resolution is as expected set to the best commonly available resolution.

REPOSITORY
  R110 KScreen Library

REVISION DETAIL
  https://phabricator.kde.org/D6011

AFFECTED FILES
  backends/xrandr/xrandrconfig.cpp

To: clutz
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170529/678fd9f5/attachment.html>