D5973: Always add data sources in SystemMonitorEngine::sourceRequestEvent()
Elvis Angelaccio
noreply at phabricator.kde.org
Fri May 26 09:22:53 UTC 2017
elvisangelaccio created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
Otherwise if we show the plasma-nm applet twice, m_sensors won't be empty
and we won't be able to fect the connection speed data.
git blame points to
https://github.com/KDE/kde-workspace/commit/ba7444f99ab08cf0a305899bf66879314bd0d5a9
and
https://github.com/KDE/kde-workspace/commit/235fea1868b560acf32c5c13a3d16ef233b50be6
but they don't really explain why setData() was called only if m_sensors
was empty.
BUG: 380209
TEST PLAN
- plasmoidviewer -a org.kde.plasma.networkmanagement
- open the networkmanager appler twice
- make sure the connection's speed graph works the 2nd time.
REPOSITORY
R120 Plasma Workspace
BRANCH
Plasma/5.8
REVISION DETAIL
https://phabricator.kde.org/D5973
AFFECTED FILES
dataengines/systemmonitor/systemmonitor.cpp
To: elvisangelaccio, #plasma, jgrulich
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170526/32eb0a6a/attachment.html>
More information about the Plasma-devel
mailing list