D5910: make shadows work on wayland

Marco Martin noreply at phabricator.kde.org
Fri May 19 11:01:40 UTC 2017


mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in breezeshadowhelper.cpp:177
> we use Expose everywhere else, why not here? It gets called a lot less

it's a qwidget, doesn't get expose events

> davidedmundson wrote in breezeshadowhelper.cpp:464
> this is currently leaking?
> 
> fromWindow constructs a new QObject

it should index those by widget as well i guess, then using this to keep track as opposed to repurposing the _widgets map

REPOSITORY
  R31 Breeze

REVISION DETAIL
  https://phabricator.kde.org/D5910

To: mart, #plasma, hpereiradacosta
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170519/26e4f55d/attachment-0001.html>


More information about the Plasma-devel mailing list