D5910: make shadows work on wayland
Hugo Pereira Da Costa
noreply at phabricator.kde.org
Thu May 18 15:07:57 UTC 2017
hpereiradacosta added inline comments.
INLINE COMMENTS
> breezeshadowhelper.cpp:177
> + QWidget* widget( static_cast<QWidget*>( object ) );
> + if( event->type() == QEvent::Paint && ( !_widgets.contains(widget) || _widgets.value(widget) == 0 ) )
> + {
Also, instead of using first "contains" then .value, one should really use an iterator (to avoid parsing the map twice):
auto&& iter = _widgets.find( widget );
if( iter == _widgets.end() || iter.value() == 0 )
Something like that.
REPOSITORY
R31 Breeze
REVISION DETAIL
https://phabricator.kde.org/D5910
To: mart, #plasma, hpereiradacosta
Cc: anthonyfieroni, davidedmundson, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170518/f1c0bcd0/attachment.html>
More information about the Plasma-devel
mailing list