D5748: workaround for correct wayland positioning

Marco Martin noreply at phabricator.kde.org
Mon May 15 16:04:19 UTC 2017


mart marked 2 inline comments as done.
mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in view.cpp:248
> When we get here we've already run Dialog::event()
> 
> won't that have already done the positioning?
> 
> There's a virtual geometry method in dialog to allow krunner and such to be different

no, it doesn-t seem.
at that point it executed expose of dialog::event,
this calls dialog::updateVisibility which moves the dialog only when it has a visualparent.
i don't think the virtual popupposition may be repurposed for this case.
may be worth a deeper look on what's the exact event sequence tough

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D5748

To: mart, #plasma, #plasma_on_wayland
Cc: davidedmundson, graesslin, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, eliasp, sebas, apol, hein, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170515/e58f4a01/attachment.html>


More information about the Plasma-devel mailing list