D5564: Man ioslave: Port away from KDELibs4Support

[David Faure]

dfaure added inline comments.

INLINE COMMENTS

> kio_man.cpp:247
> +            QString lang = QLocale::languageToString((*it_loc).language());
> +            if ( !lang.isEmpty() && lang!=QString("C") ) {
> +                QString dir = (*it_dir) + '/' + lang;

keep the spaces around !=

> man2html.cpp:6014
>  #else
>      output_real("Generated by kio_man, KDE version ");
> +    output_real(QString(PLASMA_VERSION_STRING).toHtmlEscaped().toLocal8Bit());

remove "KDE", you can't version a community ;)

> man2html.cpp:6015
>      output_real("Generated by kio_man, KDE version ");
> -    output_real(Qt::escape(QLatin1String(KDE_VERSION_STRING)).toUtf8());
> +    output_real(QString(PLASMA_VERSION_STRING).toHtmlEscaped().toLocal8Bit());
>  #endif

why PLASMA? This is kde/kdenetwork/kio-extras, usable outside of a plasma workspace. I'm curious where PLASMA_VERSION_STRING even comes from !?

REPOSITORY
  R320 KIO Extras

REVISION DETAIL
  https://phabricator.kde.org/D5564

To: marten, #plasma, dfaure, mart
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170509/d9d4c0a0/attachment.html>