D5778: [backlighthelper] Remove unreachable code from backlighthelper
Bhushan Shah
noreply at phabricator.kde.org
Mon May 8 21:07:56 UTC 2017
bshah created this revision.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.
REVISION SUMMARY
- It looks if we are on FreeBSD, then it sets the USE_SYSCTL
- If USE_SYSCTL is set, it will try to use acpi_video interface to set
the brightness
- However, this whole upower backend depends on libudev which is not
available on FreeBSD and it doesn't compile and link with FreeBSD
I propose to remove this code from here, and add it back when we split
out the backlighthelper from the upower backend
TEST PLAN
builds and works on Linux
REPOSITORY
R122 Powerdevil
BRANCH
remove-unreachable-code
REVISION DETAIL
https://phabricator.kde.org/D5778
AFFECTED FILES
daemon/backends/upower/backlighthelper.cpp
daemon/backends/upower/backlighthelper.h
To: bshah, #plasma, #freebsd, broulik
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170508/0fa97515/attachment.html>
More information about the Plasma-devel
mailing list