D5764: Add support for remote image sources to DesktopIcon

Marco Martin noreply at phabricator.kde.org
Mon May 8 19:06:49 UTC 2017


mart accepted this revision.
mart added inline comments.
This revision is now accepted and ready to land.

INLINE COMMENTS

> desktopicon.cpp:366
>          }
> +    } else if(iconSource.startsWith("http://") || iconSource.startsWith("https://")) {
> +        if(!m_loadedImage.isNull()) {

coding style, space between if and ( 
(in some other places as well)

REPOSITORY
  R169 Kirigami

REVISION DETAIL
  https://phabricator.kde.org/D5764

To: leinir, mart, apol
Cc: plasma-devel, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170508/95e7dc85/attachment-0001.html>


More information about the Plasma-devel mailing list