D5232: Add override to methods that override methods on their parent class

[Martin Gräßlin]

graesslin added a comment.


  In https://phabricator.kde.org/D5232#98698, @apol wrote:
  
  > In https://phabricator.kde.org/D5232#98689, @graesslin wrote:
  >
  > > I would prefer if this IMHO useless warning gets disabled.
  >
  >
  > `override` adds useful semantics to your code, that's never useless.
  >
  > Oh well...
  
  
  A warning which breaks the warning output of legacy code (and that's what KWin is) is completely useless. Yes override is cool and useful. And KWin uses it in new code. But adjusting the old code - no that just makes the git history a mess. Nobody touches that code, nobody will change it.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5232

To: apol, #plasma, graesslin, davidedmundson
Cc: luebking, plasma-devel, kwin, #kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170329/f528a963/attachment.html>