D5227: Add a configuration option to hide the show password button

[Martin Gräßlin]

graesslin requested changes to this revision.
graesslin added a comment.
This revision now requires changes to proceed.


  As already outlined in your thread on distributions I think this is wrong. And as the maintainer of the lock screen I'm against adding this option to the lock screen. It's the typical KDE 3 approach of not knowing what we want to do, so we offer an option.
  
  If your concern is that the clipboard content gets restored then let's work on this. It is very simple to restore the clipboard with the help of Klipper, but as I already outlined I won't be able to do it as I'm on Wayland.
  
  So overall: -2 from maintainer perspective.

INLINE COMMENTS

> greeterapp.cpp:369-374
> +    if (KScreenSaverSettings::self()->enableShowPassword()) {
> +        QGuiApplication::clipboard()->clear();
> +        QGuiApplication::clipboard()->clear(QClipboard::Selection);
> +    }
>  }
>  

This is absolutely unrelated to the config option. Why should the clipboard safety feature be combined with show password.

Please note that we got bug reports about this years before we offered the show password.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D5227

To: fvogt, #plasma, graesslin
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170328/39c3acdb/attachment-0001.html>