D5182: Ensure PointerInputRedirection::processMotion finishes prior to warping

[Martin Gräßlin]

graesslin added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in pointer_input.cpp:234-236
> This can lead to strange side effect
> 
> 1. isPositionBlocked == true
> 2. s_scheduledPositions.size() > 1
> 3. isPositionBlocked == false
> 4. s_scheduledPositions.size() - 1 but still not 0
> 
> In next block/unblock will be triggered pertty old motion event, no? Maybe it's better to steal all blocked events except last one.

No it is fine. You need to look at the big picture. This will invoke the first queued element for processMotion. Which in turn creates a new blocker and when going out of processMotion the next item will be processed. It is a recursive dequeueing of all elements. If another motion gets scheduled it just gets put to the end of the queue.

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D5182

To: graesslin, #kwin, #plasma
Cc: anthonyfieroni, plasma-devel, kwin, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170326/efa0f5bf/attachment.html>