D5169: Port away from KDELibs4Support

Christoph Feck noreply at phabricator.kde.org
Fri Mar 24 21:52:24 UTC 2017


cfeck added inline comments.

INLINE COMMENTS

> kpci.cpp:96
>  		//		line.setAscii(nameBuffer); //not work, workaround below
> -		line = QString::fromAscii(pci_lookup_name(PCIAccess, nameBuffer, NAME_BUFFER_SIZE, PCI_LOOKUP_VENDOR, info->cooked.vendor, 0, 0, 0));
> +        line = QString::fromLatin1(pci_lookup_name(PCIAccess, nameBuffer, NAME_BUFFER_SIZE, PCI_LOOKUP_VENDOR, info->cooked.vendor, 0, 0, 0));
>  		if (line.contains(QStringLiteral("Unknown"))==0) {

Check the indentation (tabs vs spaces?) Always view with a tabsize of 8 positions.

REPOSITORY
  R102 KInfoCenter

REVISION DETAIL
  https://phabricator.kde.org/D5169

To: rthomsen, #plasma, elvisangelaccio
Cc: cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170324/575cc8e1/attachment.html>


More information about the Plasma-devel mailing list