<table><tr><td style="">cfeck added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5169" rel="noreferrer">View Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5169#inline-21240" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">kpci.cpp:96</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #74777d">//    line.setAscii(nameBuffer); //not work, workaround below</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"><span class="bright">    </span><span class="n">line</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">from<span class="bright">Ascii</span></span><span class="p">(</span><span class="n">pci_lookup_name</span><span class="p">(</span><span class="n">PCIAccess</span><span class="p">,</span> <span class="n">nameBuffer</span><span class="p">,</span> <span class="n">NAME_BUFFER_SIZE</span><span class="p">,</span> <span class="n">PCI_LOOKUP_VENDOR</span><span class="p">,</span> <span class="n">info</span><span style="color: #aa2211">-></span><span class="n">cooked</span><span class="p">.</span><span class="n">vendor</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="bright">        </span><span class="n">line</span> <span style="color: #aa2211">=</span> <span class="n">QString</span><span style="color: #aa2211">::</span><span class="n">from<span class="bright">Latin1</span></span><span class="p">(</span><span class="n">pci_lookup_name</span><span class="p">(</span><span class="n">PCIAccess</span><span class="p">,</span> <span class="n">nameBuffer</span><span class="p">,</span> <span class="n">NAME_BUFFER_SIZE</span><span class="p">,</span> <span class="n">PCI_LOOKUP_VENDOR</span><span class="p">,</span> <span class="n">info</span><span style="color: #aa2211">-></span><span class="n">cooked</span><span class="p">.</span><span class="n">vendor</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">,</span> <span style="color: #601200">0</span><span class="p">));</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">    <span style="color: #aa4000">if</span> <span class="p">(</span><span class="n">line</span><span class="p">.</span><span class="n">contains</span><span class="p">(</span><span class="n">QStringLiteral</span><span class="p">(</span><span style="color: #766510">"Unknown"</span><span class="p">))</span><span style="color: #aa2211">==</span><span style="color: #601200">0</span><span class="p">)</span> <span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Check the indentation (tabs vs spaces?) Always view with a tabsize of 8 positions.</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R102 KInfoCenter</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5169" rel="noreferrer">https://phabricator.kde.org/D5169</a></div></div><br /><div><strong>To: </strong>rthomsen, Plasma, elvisangelaccio<br /><strong>Cc: </strong>cfeck, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>