D5137: Add support for screenedge touchscreen events through XInput 2.2

[David Edmundson]

davidedmundson added a comment.


  cool

INLINE COMMENTS

> xinputintegration.cpp:132
> +                m_lastTouchPosition = touchPosition;
> +                m_lastTouchPositions.insert(m_trackingTouchId, touchPosition);
> +            }

I think we want to always update m_lastTouchPositions outside of 
if (e->detail == m_trackingTouchId)

otherwise if we get:

TouchBegin
TouchUpdate
TouchOwnership

we start the gesture in the wrong position

> xinputintegration.cpp:188
>      QPointer<X11Cursor> m_x11Cursor;
> +    QPointF m_lastTouchPosition;
> +    Display *m_x11Display = nullptr;

what's this for?

REVISION DETAIL
  https://phabricator.kde.org/D5137

To: graesslin, #plasma, #kwin
Cc: davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/e0ac78bc/attachment.html>