<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D5137" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>cool</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5137#inline-21117" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xinputintegration.cpp:132</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">m_lastTouchPosition</span> <span style="color: #aa2211">=</span> <span class="n">touchPosition</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">                <span class="n">m_lastTouchPositions</span><span class="p">.</span><span class="n">insert</span><span class="p">(</span><span class="n">m_trackingTouchId</span><span class="p">,</span> <span class="n">touchPosition</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">            <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">I think we want to always update m_lastTouchPositions outside of <br />
if (e->detail == m_trackingTouchId)</p>

<p style="padding: 0; margin: 8px;">otherwise if we get:</p>

<p style="padding: 0; margin: 8px;">TouchBegin<br />
TouchUpdate<br />
TouchOwnership</p>

<p style="padding: 0; margin: 8px;">we start the gesture in the wrong position</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D5137#inline-21116" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">xinputintegration.cpp:188</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">    <span class="n">QPointer</span><span style="color: #aa2211"><</span><span class="n">X11Cursor</span><span style="color: #aa2211">></span> <span class="n">m_x11Cursor</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">QPointF</span> <span class="n">m_lastTouchPosition</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span class="n">Display</span> <span style="color: #aa2211">*</span><span class="n">m_x11Display</span> <span style="color: #aa2211">=</span> <span style="color: #aa4000">nullptr</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">what's this for?</p></div></div></div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D5137" rel="noreferrer">https://phabricator.kde.org/D5137</a></div></div><br /><div><strong>To: </strong>graesslin, Plasma, KWin<br /><strong>Cc: </strong>davidedmundson, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol<br /></div>