D5086: Applet: Add Raise maximum volume action to context menu

Chris Holland noreply at phabricator.kde.org
Thu Mar 23 01:10:28 UTC 2017


Zren added a comment.


  Looks good.
  
  F3126554: 2017-03-22___20-56-01.png <https://phabricator.kde.org/F3126554>
  
  There's one issue I want to point out that I dealt with, is that other instances of the widget won't be in the "raised" state (eg: other screens).
  
  Example: https://streamable.com/go1u7
  
  My solution was:
  https://github.com/Zren/plasma-applets/blob/master/org.kde.plasma.volumewin7mixer/package/contents/ui/MixerItem.qml#L372-L379
  
    property int volume: PulseObject.volume
    onVolumeChanged: {
        ignoreValueChange = true;
        if (!mixerItem.isVolumeBoosted && PulseObject.volume > maximumValue) {
            mixerItem.isVolumeBoosted = true;
        }
        value = PulseObject.volume;
        ignoreValueChange = false;
    }

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D5086

To: drosca, #plasma
Cc: Zren, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170323/f907e52f/attachment-0001.html>


More information about the Plasma-devel mailing list