Review Request 129838: fix no-display of CPU bars per core (and fix some warnings)

[Martin Koller]

> On Jan. 16, 2017, 8:40 a.m., Kåre Särs wrote:
> > The current/old version uses "connectSource(source)" to add the CPUs when they are added in onSourceAdded, but that is not good if the sources are added before SystemLoadViewer.qml (a problem when adding a second SytemLoadViewer)
> > 
> > I'm fine with this change, but it seems indeed strange that you first only connect "system/cores"
> > 
> > What happens if you use connectSource(...) in onNewData in stead of setting all of connectedSources again?
> 
> Martin Koller wrote:
>     Sorry, I don't understand your question.
>     I'm first connecting to the system/cores only to know how many cores there are since this information is needed to know (calculate) what is the effective sources array I want in the end.
>     Therefore:
>     step 1) get #cores
>     step 2) get list of all needed sources including those which are indexed by the core-idx
>     step 3) connect this final list of sources
>     
>     What is wrong with this approach ?

Anything I need to clarify ?
or can this path be applied, please ?


- Martin


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129838/#review102056
-----------------------------------------------------------


On Jan. 15, 2017, 2:36 p.m., Martin Koller wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129838/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 2:36 p.m.)
> 
> 
> Review request for Plasma and Kåre Särs.
> 
> 
> Bugs: 373776
>     http://bugs.kde.org/show_bug.cgi?id=373776
> 
> 
> Repository: kdeplasma-addons
> 
> 
> Description
> -------
> 
> See bug #373776
> The CPU bars do not show a value when using separate bars per CPU, and the tooltip never
> shows a value per CPU, since the data sources per CPU are not subscribed.
> 
> AFAICT this could never have worked.
> 
> 
> Diffs
> -----
> 
>   applets/systemloadviewer/package/contents/ui/CompactBarMonitor.qml 32d98dd 
>   applets/systemloadviewer/package/contents/ui/SystemLoadViewer.qml 5a0bc06 
> 
> Diff: https://git.reviewboard.kde.org/r/129838/diff/
> 
> 
> Testing
> -------
> 
> yes
> 
> 
> Thanks,
> 
> Martin Koller
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170319/6da3ef50/attachment.html>