D4893: Layout and animations on the on screen keyboard
Marco Martin
noreply at phabricator.kde.org
Thu Mar 16 11:53:29 UTC 2017
mart added inline comments.
INLINE COMMENTS
> mart wrote in LockScreenUi.qml:113
> i see that commit puts the clock in a column layout together with just an empty item.. why? looks like some easy cleanup can be done there
>
> in adapting to that diff, now hiding the user icon when it goes over the clock, but i think the clock sliding away was actually more correct ui-wise
purely ui-wise, i think the correct behavior of the clock (for a future review) should be:
- stay at top of the screen
- either disappear or slide away when the user icon starts to overlap it. Either always disappears, or slides when it's pushed away when the keyboard is open and disappears when it's pushed away and the keyboard is closed (very very tiny screen resolution)
- user icon disappears as before when it starts to go out of the screen
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D4893
To: mart, graesslin, #plasma
Cc: plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170316/dcdda5e8/attachment.html>
More information about the Plasma-devel
mailing list