D5029: Use seccomp for implementing a sandbox for kscreenlocker_greet

Kai Uwe Broulik noreply at phabricator.kde.org
Sun Mar 12 16:28:34 UTC 2017


broulik added a comment.


  Cool!

INLINE COMMENTS

> seccomp_test.cpp:95
> +    QFETCH(QString, url);
> +    QNetworkRequest request(url);
> +    auto reply = manager.get(request);

set `QNetworkRequest::FollowRedirectsAttribute` or else Ben will get angry

> greeterapp.cpp:148
> +        return new Authenticator(Authenticator::AuthenticationMode::Delayed, this);
> +    }
> +#endif

Might lead to an unreachable code warning?

REVISION DETAIL
  https://phabricator.kde.org/D5029

To: graesslin, #plasma
Cc: broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170312/b695cd60/attachment.html>


More information about the Plasma-devel mailing list