D4939: Get rid of KDELibs4Support

Alexander Volkov noreply at phabricator.kde.org
Tue Mar 7 13:26:54 UTC 2017


volkov added inline comments.

INLINE COMMENTS

> denisshienkov wrote in CMakeLists.txt:111
> Where I need to take an appropriate XML files then?

Copy them here.

> denisshienkov wrote in powerdevilcore.cpp:102
> > It seems to be more reasonable to request supported methods from powerdevil daemon by dbus calllings
> 
> Ok, maybe then I can take a suggestion from @graesslin ?
> 
> "Just as an FYI: I reimplemented parts of the API in kscreenlocker. This code could be used here as well."

Yes, powermanagement.{h, cpp} from kscreenlocker is what you need.
The question is whether to create a library from it?

> denisshienkov wrote in activitypage.cpp:76
> Then it does not compiled with Qt5 (without of KDELibs4Support).

Why don't make QWeakPointer -> QPointer commit first and base this one on it?

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4939

To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170307/44227470/attachment.html>


More information about the Plasma-devel mailing list