D4939: Get rid of KDELibs4Support

[Denis Shienkov]

denisshienkov added inline comments.

INLINE COMMENTS

> volkov wrote in CMakeLists.txt:111
> I guess it can be just removed. These kf5_org.* files were dropped from solid three years ago.

Where I need to take an appropriate XML files then?

> volkov wrote in CMakeLists.txt:22
> Is it necessary to add KF5::Solid?

I will try later.

> volkov wrote in powerdevilcore.cpp:102
> And who will set backend for Core?
> 
> Now I think that it was a bad idea to request supported suspend methods from a backend, 
> because GUI doesn't depend on it. You need to load the backend in GUI, it will do some initialization...
> 
> It seems to be more reasonable to request supported methods from powerdevil daemon by dbus calllings
> org.freedesktop.PowerManagement.{CanSuspend, CanHibernate, CanHybridSuspend}

> It seems to be more reasonable to request supported methods from powerdevil daemon by dbus calllings

Ok, maybe then I can take a suggestion from @graesslin ?

"Just as an FYI: I reimplemented parts of the API in kscreenlocker. This code could be used here as well."

> volkov wrote in powerdevilcore.cpp:107
> unrelated

ok

> volkov wrote in activitypage.cpp:76
> Shouldn't it be in a separate change?

Then it does not compiled with Qt5 (without of KDELibs4Support).

REPOSITORY
  R122 Powerdevil

REVISION DETAIL
  https://phabricator.kde.org/D4939

To: denisshienkov, volkov, afiestas
Cc: graesslin, davidedmundson, broulik, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170307/24395b91/attachment.html>