D4965: Remove ifdef round qCDebugs

[David Edmundson]

davidedmundson added a comment.


  In https://phabricator.kde.org/D4965#93205, @graesslin wrote:
  
  > The ifdefs are from kde4 times. There it was also not needed, but nevertheless there. When working on the qt5 port I kept that under the assumption that the previous maintainer had a good reason for ifdefing it. Looking at the code I doubt it is side effect free. E.g. lines 694 following look dangerous to me. In fact I wouldn't guarantee that this won't result in a crash on wayland.
  
  
  I'll remove the ones using m_clip, you're right that they're not const methods, so could potentially throw off any debug anyway.
  
  > The code paths have not been used in production for years.
  
  That will also still effectively be the case here.
  qCDebug() isn't a function like qDebug() but a very clever macro. The rest of the line is only evaluated if that category logging is enabled.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4965

To: davidedmundson, #plasma, graesslin
Cc: graesslin, plasma-devel, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170307/512154c1/attachment.html>