D6443: [CurrentContainmentActionsModel] Add configurationChanged signal

Kai Uwe Broulik noreply at phabricator.kde.org
Fri Jun 30 09:39:08 UTC 2017


broulik added inline comments.

INLINE COMMENTS

> currentcontainmentactionsmodel.cpp:217
>      QObject::connect(configDlg, &QDialog::accepted, pluginInstance,
> -            [configDlg, pluginInstance] () {
> +            [this, configDlg, pluginInstance] () {
>                  pluginInstance->configurationAccepted();

Hmm I pass in "this" but it's nowhere guarded :/

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D6443

To: broulik, #plasma
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170630/f6bc3026/attachment-0001.html>


More information about the Plasma-devel mailing list