D6313: WIP: Support device pixel ratio in icon loader and engine

Marco Martin noreply at phabricator.kde.org
Mon Jun 26 08:58:58 UTC 2017


mart added a comment.


  In https://phabricator.kde.org/D6313#118285, @kvermette wrote:
  
  > Behaviorally speaking there's justification for ensuring SVGs are treated the same as PNGs in this case. Looking at the code we aren't shimming the SVGs specifically (unless I'm missing something), but I just wanted to chime in with this and nip special treatment for SVGs in the bud. In maintaining the Aether icon theme I would create links to the higher resolution icons, so you'd see something like a "16x16x2" folder point to my "32x32" 'native' folder, and a "16x16x3"->"48x48" folder, "32x32x2"->"64x64", etc. Just because we *can* scale SVG icons doesn't mean that behavior should be assumed, should the icon set have higher fidelity icons ready for HiDPI.
  
  
  i think for svgs 16x16x2 should be preferred over scaling by 2 the 16x16 version, but still, scaling the 16x16 version should still be preferred over the 32x32 version, so this patch is on the right rirection

REPOSITORY
  R302 KIconThemes

REVISION DETAIL
  https://phabricator.kde.org/D6313

To: broulik, kde-frameworks-devel, #plasma, #vdg
Cc: mart, kvermette, cfeck, davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170626/59973288/attachment-0001.html>


More information about the Plasma-devel mailing list