D6322: [FolderView] Don't calculate extra spacing when we don't need to.

Chris Holland noreply at phabricator.kde.org
Wed Jun 21 20:04:27 UTC 2017


Zren added inline comments.

INLINE COMMENTS

> hein wrote in FolderView.qml:492
> Maybe I'm blind, but you're linking to a definition of a 'ready' prop in a different file. FolderView.qml can't depend on a property in main.qml, this will e.g. break in FolderViewDialog. And yeah, disambiguification is good ...

Ready is defined right here https://i.imgur.com/fvRe3CI.png
The definition, assignment, and usage are all within 10 lines from each other so I didn't think I needed the `scrollView.` prefix but I might as well in case stuff is moved around later.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6322

To: Zren, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170621/9f92dbf4/attachment-0001.html>


More information about the Plasma-devel mailing list