D6322: [FolderView] Don't calculate extra spacing when we don't need to.

[Eike Hein]

hein added inline comments.

INLINE COMMENTS

> Zren wrote in FolderView.qml:492
> Arg, curses.
> 
> `ready` is defined 2 lines up. Also, do you want me to put `scrollArea.ready` so it's not confused with `folderViewLayer.ready` defined in `main.qml`?
> 
> https://github.com/KDE/plasma-desktop/blob/master/containments/desktop/package/contents/ui/main.qml#L405

Maybe I'm blind, but you're linking to a definition of a 'ready' prop in a different file. FolderView.qml can't depend on a property in main.qml, this will e.g. break in FolderViewDialog. And yeah, disambiguification is good ...

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6322

To: Zren, hein
Cc: plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170621/f8379605/attachment.html>