D6215: Make sure size is final after showEvent

[David Edmundson]

davidedmundson added a comment.


  > no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent,
  
  Ok, great
  
  ----
  
  It's somewhat confusing as you have multiple completely independent attempts to solve the same problem.
  
  We have a patch now consists of:
  
  1. an early mainItem->setVisible()
  2. always updating the platform window size regardless of whether it's visible
  3. some other wayland changes (which aren't in your commit message)
  
  And we have another patch that:
  
  4. removes use of item::visible in working out window size
  5. inhibits resizing whilst we re-populate actions whilst invisible
  
  I'm after some explanation of what the problem(s) each one of those is solving.
  
  If 1 works, I don't see what 2 accomplishes, you're setting the platform window size earlier, but to something that we know is wrong.
  
  Also if 1 works, we don't need 4 or 5? Unless it's because notification does is doing the positioning before the show event?  At which point we could just fix that more normally.

INLINE COMMENTS

> dialog.cpp:1179
>              d->updateVisibility(true);
> +            d->updateTheme();
>          }

what's this about?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D6215

To: mart, #plasma, davidedmundson
Cc: sebas, hein, davidedmundson, plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170621/9a94e0ab/attachment-0001.html>