<table><tr><td style="">davidedmundson added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6215" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #a7b5bf; color: #464c5c; font-style: italic; margin: 4px 0 12px 0; padding: 4px 12px; background-color: #f8f9fc;"><p>no, it just means that who calls show() or the wrong setVisible() would just get the previous behavior of mainItem being shown only at showevent,</p></blockquote>
<p>Ok, great</p>
<hr class="remarkup-hr" />
<p>It's somewhat confusing as you have multiple completely independent attempts to solve the same problem.</p>
<p>We have a patch now consists of:</p>
<ol class="remarkup-list">
<li class="remarkup-list-item">an early mainItem->setVisible()</li>
<li class="remarkup-list-item">always updating the platform window size regardless of whether it's visible</li>
<li class="remarkup-list-item">some other wayland changes (which aren't in your commit message)</li>
</ol>
<p>And we have another patch that:</p>
<ol class="remarkup-list" start="4">
<li class="remarkup-list-item">removes use of item::visible in working out window size</li>
<li class="remarkup-list-item">inhibits resizing whilst we re-populate actions whilst invisible</li>
</ol>
<p>I'm after some explanation of what the problem(s) each one of those is solving.</p>
<p>If 1 works, I don't see what 2 accomplishes, you're setting the platform window size earlier, but to something that we know is wrong.</p>
<p>Also if 1 works, we don't need 4 or 5? Unless it's because notification does is doing the positioning before the show event? At which point we could just fix that more normally.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6215#inline-25976" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">dialog.cpp:1179</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">updateVisibility</span><span class="p">(</span><span style="color: #304a96">true</span><span class="p">);</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"> <span class="n">d</span><span style="color: #aa2211">-></span><span class="n">updateTheme</span><span class="p">();</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="p">}</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">what's this about?</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework (Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6215" rel="noreferrer">https://phabricator.kde.org/D6215</a></div></div><br /><div><strong>To: </strong>mart, Plasma, davidedmundson<br /><strong>Cc: </strong>sebas, hein, davidedmundson, plasma-devel, Frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, apol, mart, lukas<br /></div>