D6004: Add method to unlock greeter via consolekit.

[Tobias C. Berner]

tcberner added inline comments.

INLINE COMMENTS

> graesslin wrote in CMakeLists.txt:78
> I would keep this information about the contact. We want to be friendly here and it's such a touchy topic that I prefer to be very explicit that we do want to support other solutions.

Ok.

> graesslin wrote in CMakeLists.txt:81-87
> I would prefer if we only search for one of the two. What I want to not have is a situation where we get false positive warnings about missing runtime components. E.g. if your distro is using logind there is just no point in looking for ConsoleKit and it would now produce a false positive runtime warning. The same applies the other way around.
> 
> Maybe we could work with add_feature_info?

Ok, I'll adapt it.

> graesslin wrote in abstractlocker.cpp:62
> cant we make the bash script just do what it is supposed to do?

I'm not sure, if we can predictably get the name of the correct "broken" session from within the script -- of course, the script could just unlock all the sessions by iterating over them, but that seems rude. Maybe the error message `text` could be modified to contain correct session name:

  "# ck-unlock-session [the current session name]\n\n"

> graesslin wrote in abstractlocker.cpp:67-70
> I would scrap that part. It's too technical and doesn't help the user.

I think seeing this message annoys the users. So pointing them to possible solutions for future failures is a good thing, even when it might be a bit technical.

> graesslin wrote in ck-unlock-session.cmake:17
> Is this asking for the password in some way? Or do we now install a script which allows to bypass authentication? With logind one can configure the system to always require a password.

It does not ask for a password, but by default, only root should be able to do it.

> graesslin wrote in FindConsoleKit.cmake:28
> just wondering: why dbus-send and not qdbus? qdbus would be a binary our session depends on anyway.

No reason, just didn't think of it. I will try to change it to qdbus.

REPOSITORY
  R133 KScreenLocker

REVISION DETAIL
  https://phabricator.kde.org/D6004

To: tcberner, #freebsd, graesslin, #plasma
Cc: erichameleers, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170614/99d199d5/attachment-0001.html>