D6164: Make shadows work for windows 100% width or height

[Marco Martin]

mart added a comment.


  +1

INLINE COMMENTS

> scene_opengl.cpp:2358
>  
> -    const int width = qMax(topLeft.width(), bottomLeft.width()) +
> +    const int width = qMax3(topLeft.width(), left.width(), bottomLeft.width()) +
>                        qMax(top.width(), bottom.width()) +

oh, i get it now, i like that logic

> utils.h:205
> +template <typename T>
> +T qMax3(const T &value1, const T &value2, const T &value3)
> +{

not sure about calling a local function qMax3, it would suggest it comes from qt.

maybe utilsMax3 or something without q

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6164

To: davidedmundson, #plasma
Cc: mart, plasma-devel, kwin, #kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170612/99f6415b/attachment.html>