<table><tr><td style="">mart added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6164" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>+1</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6164#inline-25428" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_opengl.cpp:2358</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">width</span> <span style="color: #aa2211">=</span> <span class="n">qMax</span><span class="p">(</span><span class="n">topLeft</span><span class="p">.</span><span class="n">width</span><span class="p">(),</span> <span class="n">bottomLeft</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);">    <span style="color: #aa4000">const</span> <span style="color: #aa4000">int</span> <span class="n">width</span> <span style="color: #aa2211">=</span> <span class="n">qMax<span class="bright">3</span></span><span class="p">(</span><span class="n">topL<span class="bright">eft</span></span><span class="bright"></span><span class="p"><span class="bright">.</span></span><span class="bright"></span><span class="n"><span class="bright">width</span></span><span class="bright"></span><span class="p"><span class="bright">(),</span></span><span class="bright"> </span><span class="n"><span class="bright">l</span>eft</span><span class="p">.</span><span class="n">width</span><span class="p">(),</span> <span class="n">bottomLeft</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">+</span>
</div><div style="padding: 0 8px; margin: 0 4px; ">                      <span class="n">qMax</span><span class="p">(</span><span class="n">top</span><span class="p">.</span><span class="n">width</span><span class="p">(),</span> <span class="n">bottom</span><span class="p">.</span><span class="n">width</span><span class="p">())</span> <span style="color: #aa2211">+</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">oh, i get it now, i like that logic</p></div></div><br /><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6164#inline-25427" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">utils.h:205</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">template</span> <span style="color: #aa2211"><</span><span style="color: #304a96">typename</span> <span class="n">T</span><span style="color: #aa2211">></span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="n">T</span> <span class="n">qMax3</span><span class="p">(</span><span style="color: #aa4000">const</span> <span class="n">T</span> <span style="color: #aa2211">&</span><span class="n">value1</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">T</span> <span style="color: #aa2211">&</span><span class="n">value2</span><span class="p">,</span> <span style="color: #aa4000">const</span> <span class="n">T</span> <span style="color: #aa2211">&</span><span class="n">value3</span><span class="p">)</span>
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, .6);"><span class="p">{</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">not sure about calling a local function qMax3, it would suggest it comes from qt.</p>

<p style="padding: 0; margin: 8px;">maybe utilsMax3 or something without q</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6164" rel="noreferrer">https://phabricator.kde.org/D6164</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma<br /><strong>Cc: </strong>mart, plasma-devel, kwin, KWin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, sebas, apol, lukas<br /></div>