D6141: make shadows work for windows 100%width or height

[Thomas Lübking]

luebking added a comment.


  I think what David has in mind is a shadow constellation like
  
    o----o
    |    |
     ----
  
  with the lower edges deliberately being omitted - this will cause glitchy rendering (because the bottom edge will be stretched over the edges) - thus he's looking for an entirely casual quad handling (instead of the present one that expects a regular shape with at best some sides being entirely omitted)
  
  Marco "just" wants to make cases legal, where a window has only edges on one or two opposing sides - there should maybe an additional sanity check to ensure this: only width OR height should be zero at some point and the other value should match the sum of the other axis of the invoked left/right resp. top/bottom edges.

INLINE COMMENTS

> scene_opengl.cpp:2267
>  
>      tx2 = topLeft.width()/width;
>      ty2 = topLeft.height()/height;

This is uncaught here (and in several other occasions but is caught in the other function) and apparently (at least has been) a somewhat legal  condition ...

REPOSITORY
  R108 KWin

REVISION DETAIL
  https://phabricator.kde.org/D6141

To: mart, #plasma, #kwin, graesslin
Cc: luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170609/729af77e/attachment.html>