<table><tr><td style="">luebking added a comment.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6141" rel="noreferrer">View Revision</a></tr></table><br /><div><div><p>I think what David has in mind is a shadow constellation like</p>
<div class="remarkup-code-block" style="margin: 12px 0;" data-code-lang="text" data-sigil="remarkup-code-block"><pre class="remarkup-code" style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; padding: 12px; margin: 0; background: rgba(71, 87, 120, 0.08);">o----o
| |
----</pre></div>
<p>with the lower edges deliberately being omitted - this will cause glitchy rendering (because the bottom edge will be stretched over the edges) - thus he's looking for an entirely casual quad handling (instead of the present one that expects a regular shape with at best some sides being entirely omitted)</p>
<p>Marco "just" wants to make cases legal, where a window has only edges on one or two opposing sides - there should maybe an additional sanity check to ensure this: only width OR height should be zero at some point and the other value should match the sum of the other axis of the invoked left/right resp. top/bottom edges.</p></div></div><br /><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; text-decoration: none;" href="https://phabricator.kde.org/D6141#inline-25307" rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: bold;">scene_opengl.cpp:2267</span></div>
<div style="font: 11px/15px "Menlo", "Consolas", "Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">tx2</span> <span style="color: #aa2211">=</span> <span class="n">topLeft</span><span class="p">.</span><span class="n">width</span><span class="p">()</span><span style="color: #aa2211">/</span><span class="n">width</span><span class="p">;</span>
</div><div style="padding: 0 8px; margin: 0 4px; "> <span class="n">ty2</span> <span style="color: #aa2211">=</span> <span class="n">topLeft</span><span class="p">.</span><span class="n">height</span><span class="p">()</span><span style="color: #aa2211">/</span><span class="n">height</span><span class="p">;</span>
</div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">This is uncaught here (and in several other occasions but is caught in the other function) and apparently (at least has been) a somewhat legal condition ...</p></div></div></div></div></div><br /><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6141" rel="noreferrer">https://phabricator.kde.org/D6141</a></div></div><br /><div><strong>To: </strong>mart, Plasma, KWin, graesslin<br /><strong>Cc: </strong>luebking, mvourlakos, davidedmundson, plasma-devel, kwin, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>