D6145: Massively simplify the class DesktopPortal

Jan Grulich noreply at phabricator.kde.org
Thu Jun 8 08:40:37 UTC 2017


jgrulich requested changes to this revision.
jgrulich added a comment.
This revision now requires changes to proceed.


  In https://phabricator.kde.org/D6145#115035, @davidedmundson wrote:
  
  > Inhibit should be the same as that uses the virtual object from request.cpp which I haven't touched.
  
  
  Ok, I'll test that later. Can you please rename all portals? I would propose renaming all (Access, AppChooser, FileChooser ....) to (AccessPortal, AppChooserPortal, FileChooserPortal ...) so we can rename all methods to start with a capital letter. Then it should magically work.
  
  Btw. thank you for this change,  I had hard times at the very beginning to make all interfaces registered under one dbus path.

REPOSITORY
  R838 Flatpak Support: KDE Portal for XDG Desktop

REVISION DETAIL
  https://phabricator.kde.org/D6145

To: davidedmundson, #plasma, jgrulich
Cc: apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170608/bdee3818/attachment.html>


More information about the Plasma-devel mailing list