<table><tr><td style="">jgrulich requested changes to this revision.<br />jgrulich added a comment.<br />This revision now requires changes to proceed.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D6145" rel="noreferrer">View Revision</a></tr></table><br /><div><div><blockquote style="border-left: 3px solid #8C98B8;
color: #6B748C;
font-style: italic;
margin: 4px 0 12px 0;
padding: 8px 12px;
background-color: #F8F9FC;">
<div style="font-style: normal;
padding-bottom: 4px;">In <a href="https://phabricator.kde.org/D6145#115035" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;" rel="noreferrer">D6145#115035</a>, <a href="https://phabricator.kde.org/p/davidedmundson/" style="
border-color: #f1f7ff;
color: #19558d;
background-color: #f1f7ff;
border: 1px solid transparent;
border-radius: 3px;
font-weight: bold;
padding: 0 4px;" rel="noreferrer">@davidedmundson</a> wrote:</div>
<div style="margin: 0;
padding: 0;
border: 0;
color: rgb(107, 116, 140);"><p>Inhibit should be the same as that uses the virtual object from request.cpp which I haven't touched.</p></div>
</blockquote>
<p>Ok, I'll test that later. Can you please rename all portals? I would propose renaming all (Access, AppChooser, FileChooser ....) to (AccessPortal, AppChooserPortal, FileChooserPortal ...) so we can rename all methods to start with a capital letter. Then it should magically work.</p>
<p>Btw. thank you for this change, I had hard times at the very beginning to make all interfaces registered under one dbus path.</p></div></div><br /><div><strong>REPOSITORY</strong><div><div>R838 Flatpak Support: KDE Portal for XDG Desktop</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a href="https://phabricator.kde.org/D6145" rel="noreferrer">https://phabricator.kde.org/D6145</a></div></div><br /><div><strong>To: </strong>davidedmundson, Plasma, jgrulich<br /><strong>Cc: </strong>apol, plasma-devel, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, mart, lukas<br /></div>