D6054: Use explicit flag values or explicit constructor instead of nullptr
Friedrich W. H. Kossebau
noreply at phabricator.kde.org
Thu Jun 1 18:15:36 UTC 2017
kossebau added a comment.
Checking the diff another time I find it would be even nicer to extend `NET::Property`, `NET::Property2`, `NET::Action` & Co. to have an entry for `0` value, named `NoProperties`, `NoProperties2`, `NoActionFlags` etc. (cmp. e.g. `Qt::ItemFlags`), so those enum values could be used instead of the default constructors.
Would both be more expressive and also more balanced when used next to other flag sets assembled by the enum values (similar to
Something to consider for the future perhaps...
REPOSITORY
R278 KWindowSystem
BRANCH
nonullptrforflagsplease
REVISION DETAIL
https://phabricator.kde.org/D6054
To: kossebau, #plasma, graesslin, kfunk
Cc: plasma-devel, #frameworks, ZrenBot, spstarr, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170601/6b0e4252/attachment.html>
More information about the Plasma-devel
mailing list