D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

Hugo Pereira Da Costa noreply at phabricator.kde.org
Sat Jul 8 13:53:54 UTC 2017


hpereiradacosta added inline comments.

INLINE COMMENTS

> hpereiradacosta wrote in breezeshadowhelper.h:187
> Just to make sure (I haven't read the other review request): this change is because Registry now returns QPointer and not raw pointers ? Correct ?

... ignore. 
I guess this is just to have better test on nullptr in case the object pointed to by QPointer gets deleted elsewhere (e.g. in kwin)

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170708/9216561f/attachment.html>


More information about the Plasma-devel mailing list