D6572: [kstyle] Change ownership of Wayland objects so that KWin can delete them

Hugo Pereira Da Costa noreply at phabricator.kde.org
Sat Jul 8 13:51:32 UTC 2017


hpereiradacosta accepted this revision.
hpereiradacosta added a comment.
This revision is now accepted and ready to land.


  looks good !

INLINE COMMENTS

> breezeshadowhelper.h:187
>          //* The Wayland shadow manager to create Shadows for Surfaces (QWindow)
> -        KWayland::Client::ShadowManager* _shadowManager;
> +        QPointer<KWayland::Client::ShadowManager> _shadowManager;
>  

Just to make sure (I haven't read the other review request): this change is because Registry now returns QPointer and not raw pointers ? Correct ?

REPOSITORY
  R31 Breeze

BRANCH
  wayland-shadow-parent

REVISION DETAIL
  https://phabricator.kde.org/D6572

To: graesslin, #kwin, #plasma, hpereiradacosta
Cc: plasma-devel, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170708/326f23b1/attachment.html>


More information about the Plasma-devel mailing list