Review Request 129902: fix some bugs in kcm_colors

[Martin Koller]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129902/
-----------------------------------------------------------

(Updated Jan. 29, 2017, 2:47 p.m.)


Status
------

This change has been marked as submitted.


Review request for Plasma, Marco Martin and Olivier Churlaud.


Changes
-------

Submitted with commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller to branch master.


Bugs: 372309 and 372407
    https://bugs.kde.org/show_bug.cgi?id=372309
    https://bugs.kde.org/show_bug.cgi?id=372407


Repository: plasma-desktop


Description
-------

the new kcm_colors has some bugs which this patch addresses:

1) memory leak when opening SchemeEditorDialog (is never deleted)
2) The color preview widget can be reduced in height to nearly zero, which makes no sense
3) The scheme editor does not reflect any color change in the preview widget
4) triple-redundant widgets in the scmeditorcolors.ui file
5) user unfriendly current tab when opening the SchemeEditorDialog (I want to change a color, so the color tab shall be active)
6) Unneeded and incorrect tab index enum (enum values were not corresponding to the index the tab was inserted)
7) The SchemeEditorDialog did not just only expand the color table when enlarging the dialogs height


Diffs
-----

  kcms/colors/colorscm.cpp de5b04df 
  kcms/colors/preview.ui 0eef1ca8 
  kcms/colors/scmeditorcolors.cpp a975aea9 
  kcms/colors/scmeditorcolors.ui 87a72445 
  kcms/colors/scmeditordialog.h a49052eb 
  kcms/colors/scmeditordialog.cpp 83ab53da 

Diff: https://git.reviewboard.kde.org/r/129902/diff/


Testing
-------


Thanks,

Martin Koller

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170129/fe691ee1/attachment.html>