<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129902/">https://git.reviewboard.kde.org/r/129902/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Marco Martin and Olivier Churlaud.</div>
<div>By Martin Koller.</div>
<p style="color: grey;"><i>Updated Jan. 29, 2017, 2:47 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 1d05792ad782ce4cd41e31c1ab6eef3026b5218b by Martin Koller to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=372309">372309</a>,
<a href="https://bugs.kde.org/show_bug.cgi?id=372407">372407</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">the new kcm_colors has some bugs which this patch addresses:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">1) memory leak when opening SchemeEditorDialog (is never deleted)
2) The color preview widget can be reduced in height to nearly zero, which makes no sense
3) The scheme editor does not reflect any color change in the preview widget
4) triple-redundant widgets in the scmeditorcolors.ui file
5) user unfriendly current tab when opening the SchemeEditorDialog (I want to change a color, so the color tab shall be active)
6) Unneeded and incorrect tab index enum (enum values were not corresponding to the index the tab was inserted)
7) The SchemeEditorDialog did not just only expand the color table when enlarging the dialogs height</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/colors/colorscm.cpp <span style="color: grey">(de5b04df)</span></li>
<li>kcms/colors/preview.ui <span style="color: grey">(0eef1ca8)</span></li>
<li>kcms/colors/scmeditorcolors.cpp <span style="color: grey">(a975aea9)</span></li>
<li>kcms/colors/scmeditorcolors.ui <span style="color: grey">(87a72445)</span></li>
<li>kcms/colors/scmeditordialog.h <span style="color: grey">(a49052eb)</span></li>
<li>kcms/colors/scmeditordialog.cpp <span style="color: grey">(83ab53da)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129902/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>