Review Request 129872: [lookandfeel] Support changing window decoration

[Anthony Fieroni]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129872/
-----------------------------------------------------------

(Updated Ян. 28, 2017, 12:02 след обяд)


Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin.


Repository: plasma-desktop


Description (updated)
-------

Applying a look and feel global theme will change visual changes in:
1. Widget style
2. Color scheme
3. Icons
4. Plasma theme
5. Mouse pointer
6. Window switcher
7. Desktop switcher
8. *Window decoration*
This patch aims to implement (or correct) applying of windows decortion. When user select Oxygen look and feel (before was other no matter what) it should read default configuration for oxygen look and feel. It's located in oxygen/lookandfeel/contents/defaults (https://git.reviewboard.kde.org/r/129867/), e.g. it's look like

[kdeglobals][KDE]
widgetStyle=oxygen

[kdeglobals][General]
ColorScheme=Oxygen

[kdeglobals][Icons]
Theme=oxygen

[plasmarc][Theme]
name=air

[kcminputrc][Mouse]
cursorTheme=Oxygen_Black

[kwinrc][WindowDecoration]
library=org.kde.oxygen

In KCMLookandFeel::load() we get what package support (you see oxygen does not support changing WindowSwitcher and DesktopSwitcher)
In KCMLookandFeel::save() we read what is supported now in value e.g. library=org.kde.oxygen and write it in place that will work and kwin expects in kwinrc by function
KCMLookandFeel::setWindowDecoration kwinrc does not have a theme -> i will remove it. In DBUS calls, after writing in right place of configuration, we apply all changes.


Diffs
-----

  kcms/lookandfeel/autotests/kcmtest.cpp 29d6ec0f 
  kcms/lookandfeel/autotests/lookandfeel/contents/defaults ef3165de 
  kcms/lookandfeel/kcm.h c27b7f3d 
  kcms/lookandfeel/kcm.cpp 6ea3d050 

Diff: https://git.reviewboard.kde.org/r/129872/diff/


Testing
-------


Thanks,

Anthony Fieroni

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170128/706742ad/attachment-0001.html>