<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/129872/">https://git.reviewboard.kde.org/r/129872/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Kai Uwe Broulik, Hugo Pereira Da Costa, and Marco Martin.</div>
<div>By Anthony Fieroni.</div>
<p style="color: grey;"><i>Updated Ян. 28, 2017, 12:02 след обяд</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Applying a look and feel global theme will change visual changes in:
1. Widget style
2. Color scheme
3. Icons
4. Plasma theme
5. Mouse pointer
6. Window switcher
7. Desktop switcher
8. <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Window decoration</em>
This patch aims to implement (or correct) applying of windows decortion. When user select Oxygen look and feel (before was other no matter what) it should read default configuration for oxygen look and feel. It's located in oxygen/lookandfeel/contents/defaults (https://git.reviewboard.kde.org/r/129867/), e.g. it's look like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[kdeglobals][KDE]
widgetStyle=oxygen</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[kdeglobals][General]
ColorScheme=Oxygen</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[kdeglobals][Icons]
Theme=oxygen</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[plasmarc][Theme]
name=air</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[kcminputrc][Mouse]
cursorTheme=Oxygen_Black</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">[kwinrc][WindowDecoration]
library=org.kde.oxygen</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In KCMLookandFeel::load() we get what package support (you see oxygen does not support changing WindowSwitcher and DesktopSwitcher)
In KCMLookandFeel::save() we read what is supported now in value e.g. library=org.kde.oxygen and write it in place that will work and kwin expects in kwinrc by function
KCMLookandFeel::setWindowDecoration kwinrc does not have a theme -> i will remove it. In DBUS calls, after writing in right place of configuration, we apply all changes.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcms/lookandfeel/autotests/kcmtest.cpp <span style="color: grey">(29d6ec0f)</span></li>
<li>kcms/lookandfeel/autotests/lookandfeel/contents/defaults <span style="color: grey">(ef3165de)</span></li>
<li>kcms/lookandfeel/kcm.h <span style="color: grey">(c27b7f3d)</span></li>
<li>kcms/lookandfeel/kcm.cpp <span style="color: grey">(6ea3d050)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/129872/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>