[Differential] [Commented On] D4309: fix isOutputRedundant logic

[Marco Martin]

mart added inline comments.

INLINE COMMENTS

> davidedmundson wrote in shellcorona.cpp:1127
> there's a bug here, but I'm not sure what the right fix is.
> 
> If you have two screens A, B
> 
> both are new (so have ID == -1)
> 
> A is wider than B but B is taller than A
> 
> you return true for both.

I don't think this can happenas at this point
otherGeometry.contains(thisGeometry, false) is true, which means either:

- otherGeometry and thisGeometry have the same resolution,
- otherGeometry has both width nad height bigger then thisGeometry
- otherGeometry has the same width, but bigger height
- othergeometry has the same height but bigger width

other cases, contains would be false

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4309

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, sebas
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170127/57df763c/attachment.html>