[Differential] [Changed Subscribers] D4309: fix isOutputRedundant logic

David Edmundson noreply at phabricator.kde.org
Fri Jan 27 14:03:00 UTC 2017


davidedmundson added inline comments.

INLINE COMMENTS

> shellcorona.cpp:1127
> +             //measure of othergeometry is bigger, has a bigger area
> +             otherGeometry.width() > thisGeometry.width() ||
> +             otherGeometry.height() > thisGeometry.height() ||

there's a bug here, but I'm not sure what the right fix is.

If you have two screens A, B

both are new (so have ID == -1)

A is wider than B but B is taller than A

you return true for both.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D4309

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: mart, #plasma, sebas
Cc: davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170127/e30d7696/attachment.html>


More information about the Plasma-devel mailing list