Review Request 129835: [IconDialog] Set proper icons group

[Anthony Fieroni]

> On Jan. 21, 2017, 7:24 a.m., Anthony Fieroni wrote:
> > All IconDialogs from QML are with small and hard to visible icons e.g. Kicker (right click -> change icon -> small icons)
> 
> Anthony Fieroni wrote:
>     Ping

Marco, did you think this approach is not correct?


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129835/#review102153
-----------------------------------------------------------


On Jan. 15, 2017, 12:27 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129835/
> -----------------------------------------------------------
> 
> (Updated Jan. 15, 2017, 12:27 p.m.)
> 
> 
> Review request for Plasma, Christoph Feck and Marco Martin.
> 
> 
> Repository: kdeclarative
> 
> 
> Description
> -------
> 
> Follow the comment in IconThemes: https://api.kde.org/frameworks/kiconthemes/html/kicondialog_8cpp_source.html#l00500
> iconSize == 0 && group == KIconLoader::NoGroup
> 
> 
> Diffs
> -----
> 
>   src/qmlcontrols/kquickcontrolsaddons/icondialog.cpp be54174 
> 
> Diff: https://git.reviewboard.kde.org/r/129835/diff/
> 
> 
> Testing
> -------
> 
> Change group to Desktop, explicit size will override it.
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170127/d0859a0c/attachment.html>