[Differential] [Request, 51 lines] D4140: Rework playing of volume feedback

[David Rosca]

drosca created this revision.
drosca added a reviewer: Plasma.
Restricted Application added a project: Plasma.
Restricted Application added a subscriber: plasma-devel.

REVISION SUMMARY
  Instead of manually playing feedback immediately on user interaction
  (but with wrong, old volume), connect to volume change of all sinks and
  play the feedback there.
  
  This also means that it will play feedback even if any other application
  changes volume. If this becomes an issue, it can be changed so that the
  feedback is played only when the applet is active.
  
  Also don't cancel already playing feedback sound when playing new one
  (in case of quickly changing volume), as cancelling it produces worse
  sound (with some noise on my machine) than letting them play on top of
  each other.

TEST PLAN
  Feedback is now played with correct volume + quickly changing
  volume produces pleasant feedback sound

REPOSITORY
  R115 Plasma Audio Volume Applet

BRANCH
  feedback-rework (branched from Plasma/5.9)

REVISION DETAIL
  https://phabricator.kde.org/D4140

AFFECTED FILES
  applet/contents/ui/ListItemBase.qml
  applet/contents/ui/main.qml
  src/qml/volumefeedback.cpp

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: drosca, #plasma
Cc: plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170115/949d248f/attachment.html>