[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[Konstantin Shtepa]

konstantinshtepa added inline comments.

INLINE COMMENTS

> davidedmundson wrote in AppletAppearance.qml:445
> Edit, maybe it won't - that's why you have the separate Binding.
> 
> However changing this to:
> minimumWidth: Math.min(minimumSize.width, maximumSize.width);
> 
> for all 4
> 
> would still be a bit cleaner as then appletItem can trust these values are correct

It wouldn't work.
For example:
plasmoid.Layout.minimumHeight = 150
plasmoid.Layout.maximumHeight = 200
plasmoid.Layout.maximumHeight = 130
On third step it would think that maximumHeight = 150 and minimumHeight = 130, when it should think that maximumHeight = minimumHeight = 130.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/1bda0bd2/attachment.html>