[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:445
> +
>                  property int minimumWidth: minimumSize.width;
>                  property int minimumHeight: minimumSize.height;

Edit, maybe it won't - that's why you have the separate Binding.

However changing this to:
minimumWidth: Math.min(minimumSize.width, maximumSize.width);

for all 4

would still be a bit cleaner as then appletItem can trust these values are correct

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/057d0e3b/attachment-0001.html>