[Differential] [Commented On] D4204: Patch for plasmoid subsystem(containments/desktop) in plasma-desktop

[David Edmundson]

davidedmundson added inline comments.

INLINE COMMENTS

> AppletAppearance.qml:101
> +        if (minimumWidth > maximumWidth)
> +            maximumWidth = minimumWidth;
> +        if (width < minimumWidth) {

this is broken.

if I'm an applet and do:
Plasmoid.Layout.maximumWidth = 50

this appletItem.maximumWidth  == 58 (assuming 4px margins)
which is correct

Now if I do:

Plasmoid.Layout.minimumWidth = 60

this appletItem.maximumWidth == 68
which is also fine, we've set it to the minimum + margins

But, now if I do:

Plasmoid.Layout.maximumWidth = 70
this appletItem.maximumWidth == 68

because we've broken the binding.

We're going to need to move the

if (minimumWidth > maximumWidth)
maximumWidth = minimumWidth;

logic somewhere lower. 
Either into appletContainer or even AppletQuickItem where it does the proxying.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D4204

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: konstantinshtepa, #plasma
Cc: mart, davidedmundson, plasma-devel, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/plasma-devel/attachments/20170125/71a6d651/attachment.html>